Invalid String resource problem

[Trần Anh]

Hi,
This bug is about string in Settings.apk
Below is steps to reproduce:
- Go to Contacts setting
- Scroll down and tap "More"
- Tap Clear data

Then I search in ingbrzy's github to find out the problem and found this string with key: battery_summary in Settings.apk
- For ysl, whyred, wayne, vince, dipper, sirius... it look like (call this *1)

  <string name="battery_summary">%1$s use since last full charge</string>

- For ugg, rolex, rosy, ... it look like

  <string name="battery_summary">%1$d%% use since last full charge</string>

This issue does not happen in English or China because language pack is for every single device, I think so
The problem is happen to device which have battery_summary like 1* when using other language


Hear is the log:

 

[Trần Anh]

Another screen rendered before crash (used screen recorder to take it)
Inside the red is "Battery & performance" in English

 

[Trần Anh]

@ingbrzy @Igor Eisberg can you take a look. Thanks

 

[ingbrzy]

About which language are you talking? report it to translation repository..

 

[Trần Anh]

About which language are you talking? report it to translation repository..

I don't think it about translation. You can look at that string, some device is %d, some is %s

 

[ingbrzy]

so? it depends on app version and android version.. its translation issue..

 

[Trần Anh]

Translation can't do anything because translation is for all device

 

[ingbrzy]

of course you can translate device specific strings.. use device folder in translation..
https://github.com/MIUICzech-Slovak/MIUI-XML-10-SLOVAK/tree/master/Slovak/device

 

[Trần Anh]

Wow thanks. I don't know we can do this before. Thanks for example repository too. I'll do some work

 

[Trần Anh]

One more question, in device's folder, it contain the different string only or whole file? Thanks

 

[Trần Anh]

Okay I got it. Thanks

 

[Trần Anh]

@ingbrzy Sorry, just for clarification, I found it different from stable and weekly, a few device. That mean I must to create both original folder and _stable folder?

 

[ingbrzy]

Nope.. We do not split translations between stable and weekly.. It's disadvantage of stable versions..

 

[Trần Anh]

Okay, translation is ready for fix it Thanks